Repository navigation
Fix release to drive Homebrew Tap update - #109
Merged
Merged
Conversation
When `GITHUB_TOKEN` publishes a release, that event starts no workflow run. The tap update listens for `release: published`, so it never ran after an automatic release, and an earlier change worked around that with a tag trigger. A GitHub App token does not suppress the event, so the publish step now uses one. A published release can then start the tap update. The token comes first in the job, so a missing app install fails the run before any release exists. The create and upload steps keep `GITHUB_TOKEN`, so the app needs write access to release contents only. Change-Id: I98a9c646b27b1fcc4de81512d963c62f904c321e
The formula downloads the release archives, so its URLs exist only after the release publishes. A tag push lands before the upload, when those assets are still absent, so the tag trigger cannot fill them in. The workflow now starts on `release: published` and takes the tag from that event. `workflow_dispatch` stays, so a backfill can still name a tag by hand. The tag-push fields go away with the trigger. Change-Id: I7c9b16689e61e11ba4820b54db6d06841b48cde4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.